add word boundary to del regex to prevent false positives#1120
Open
devarjya27 wants to merge 2 commits intomandiant:masterfrom
Open
add word boundary to del regex to prevent false positives#1120devarjya27 wants to merge 2 commits intomandiant:masterfrom
devarjya27 wants to merge 2 commits intomandiant:masterfrom
Conversation
mike-hunhoff
requested changes
Feb 23, 2026
| - string: /\/c\s*del\s*/ | ||
| description: "/c del" | ||
| - string: /(^|[\&;\|]\s*)del(\s.*)?/i | ||
| - string: /(^|[\&;\|]\s*)del\b(\s.*)?/i |
Collaborator
There was a problem hiding this comment.
What about before del?
Contributor
Author
There was a problem hiding this comment.
@mike-hunhoff, Ive updated the regex. Added \b before del.
Additionally, I've added word boundaries around del in the first regex too. The new regex is /\/c\s*\bdel\b\s*/. \s* allows zero spaces, so something like /c delivery.bat could match on the del prefix of a completely benign script. . Having word boundaries across both regexes makes the rule more robust. Lmk what you think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1089
\bafterdelto ensure the pattern only matches thedelshell command as a standalone token